Skip to content

Update index.scss#1962

Open
damiandenhaag wants to merge 1 commit intonl-design-system:mainfrom
damiandenhaag:patch-2
Open

Update index.scss#1962
damiandenhaag wants to merge 1 commit intonl-design-system:mainfrom
damiandenhaag:patch-2

Conversation

@damiandenhaag
Copy link
Copy Markdown

Closing issues

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 30, 2025

@damiandenhaag is attempting to deploy a commit to the nl-design-system Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 30, 2025

⚠️ No Changeset found

Latest commit: 2443bf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +185 to +195
.utrecht-form-field--checkbox:focus-within :is(*, *::before, *::after) {
outline: none !important;
box-shadow: none !important;
-webkit-box-shadow: none !important;
}

.utrecht-form-field--checkbox:focus-within {
outline: 3px dashed #8a6f1d;
border-radius: 8px;
outline-offset: -6px;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wat betreft de checkbox zou dit niet doen. Ik zou eerder deze regel verwijderen die op regel 41 staat:
--of-utrecht-form-label-checkbox-focus-within-outline: 1px solid var(--denhaag-color-blue-4); Deze regels kunnen dan ook verwijderd worden.

Dit zorgt er voor dat die lijn rond de checkbox + label verdwijnt, en dan maken jullie gebruik van dezelfde focus als wij doen:
image
(https://nl-design-system.github.io/denhaag/?path=/story/react-formfield--checkbox-group-with-description)

Wanneer de wens van UX is om die outline om het gehele item te zetten moeten we waarschijnlijk het component van Utrecht aanpassen.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Het is inderdaad de wens van UX om de outline om het gehele item te zetten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants