Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
===========================================
- Coverage 100.00% 90.58% -9.42%
===========================================
Files 12 50 +38
Lines 694 1423 +729
Branches 100 305 +205
===========================================
+ Hits 694 1289 +595
- Misses 0 110 +110
- Partials 0 24 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bartveneman
reviewed
Jan 22, 2026
|
bartveneman
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We hebben een type Page en Category uit theme-wizard-templates, en die werd geimporteerd in theme-wizard-app. Maar theme-wizard-app importeert ook uit theme-wizard-templates, wat een build cycle error veroorzaakte.Dit heb ik tijdelijk opgelost door de type toe te voegen in theme-wizard-app, waardoor theme-wizard-app niet meer afhankelijk is van de build van theme-wizard-templates.Vraag is of dit zo moet blijven, of een andere richting kiezen, voor bijvoorbeeld een "shared" types package? Betekent wel dat je yet another package hebt en de vraag is: hoevaak gaat dit nog voorkomen?Dit heb ik gedaan, zodat de templates standalone kunnen draaien op de theme-wizard-app url, dus lokaal bijvoorbeeld: http://localhost:9492/templates/my-environment/overviewTemplateGroupinwizard-preview-pickertheme-wizard-appstonden en enkel intheme-wizard-templateswerden gebruikt, verplaatst naartheme-wizard-templatestemplate-headingvervangen doorclippy-headingen deze inpackages/clippy-componentsgeplaatsttemplate-linkvervangen doorclippy-linken deze inpackages/clippy-componentsgeplaatst. Clippy Link Webcomponent PR