Skip to content

feat: add <clippy-color-sample>#689

Merged
bartveneman merged 3 commits intomainfrom
feat/clippy-color-sample
Apr 14, 2026
Merged

feat: add <clippy-color-sample>#689
bartveneman merged 3 commits intomainfrom
feat/clippy-color-sample

Conversation

@bartveneman
Copy link
Copy Markdown
Contributor

@bartveneman bartveneman commented Apr 13, 2026

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clippy-storybook Ready Ready Preview Apr 14, 2026 8:02am
theme-wizard Ready Ready Preview Apr 14, 2026 8:02am
theme-wizard-server Ready Ready Preview Apr 14, 2026 8:02am

Request Review

@sonarqubecloud
Copy link
Copy Markdown

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.53%. Comparing base (573f4a2) to head (332ae34).
⚠️ Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   88.06%   84.53%   -3.53%     
==========================================
  Files          57       71      +14     
  Lines        1701     2173     +472     
  Branches      378      495     +117     
==========================================
+ Hits         1498     1837     +339     
- Misses        166      279     +113     
- Partials       37       57      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bartveneman bartveneman marked this pull request as ready for review April 14, 2026 08:53
@bartveneman bartveneman requested a review from a team as a code owner April 14, 2026 08:53
@bartveneman bartveneman moved this from In Progress to In review in Expertteam Digitale Toegankelijkheid 2025 Apr 14, 2026
Copy link
Copy Markdown
Contributor

@bramsmulders bramsmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we use react to render webcomponents in stories.
The Web Components Toolkit has storybook tools which we can use: https://wc-toolkit.com/integrations/storybook/
Maybe worth considering for clippy components?

@bartveneman bartveneman merged commit 3403564 into main Apr 14, 2026
10 checks passed
@bartveneman bartveneman deleted the feat/clippy-color-sample branch April 14, 2026 09:33
@bartveneman
Copy link
Copy Markdown
Contributor Author

Not sure why we chose the current approach, but sounds like a good improvement! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants