Skip to content

feat: add den haag file to themes and visual regression test#1353

Merged
jiromaykin merged 3 commits intomainfrom
feat/add-den-haag-file-to-themes-and-visual-regression-test
Mar 2, 2026
Merged

feat: add den haag file to themes and visual regression test#1353
jiromaykin merged 3 commits intomainfrom
feat/add-den-haag-file-to-themes-and-visual-regression-test

Conversation

@jiromaykin
Copy link
Copy Markdown
Contributor

@jiromaykin jiromaykin commented Feb 24, 2026

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
themes Ready Ready Preview, Comment Mar 2, 2026 11:19am

Request Review

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.51%. Comparing base (5ea4070) to head (d4dbc89).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1353   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files          19       19           
  Lines        1392     1392           
  Branches      185      185           
=======================================
  Hits         1246     1246           
  Misses        145      145           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@eslook eslook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI test laat ongewenst resultaat zien, dus ik ben dat aan het uitzoeken!

eslook
eslook previously approved these changes Mar 2, 2026
Copy link
Copy Markdown
Contributor

@eslook eslook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, context, en approving:

Eerder toen Rijkshuisstijl Community een component in themes zette, gaf dit ook ongewenste UI Tests resultaten, en dat bleek te komen door CSS contamination. Dus ik zocht naar dit specifieke probleem. Maar dit probleem lijkt dus niet voor te komen bij Den Haag; de UI Tests wijziging lijkt somehow te komen door een andere PR die gemerged is, waar die specifieke wijziging (die we hier terugzien in de UI Tests) expliciet expres in gemaakt is.

Resultaat:

  • ik approve de twee Den Haag PRs: ze zijn goed, en de UI Test wijziging komt somehow door die PR.
  • we proberen nog uit te vinden waarom dit gebeurde, en of het weer gebeurt.

Excuses voor de vertraging!

@jiromaykin jiromaykin force-pushed the feat/add-den-haag-file-to-themes-and-visual-regression-test branch from ab1e7b1 to 334a2bd Compare March 2, 2026 11:00
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 2, 2026

@jiromaykin jiromaykin merged commit 422f204 into main Mar 2, 2026
8 checks passed
@jiromaykin jiromaykin deleted the feat/add-den-haag-file-to-themes-and-visual-regression-test branch March 2, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants