Skip to content

feat: alert component zou role="status" moeten hebben voor type="info" (#2742)#2828

Merged
Robbert merged 8 commits intomainfrom
feat/2742-alert-component-zou-role-status-moeten-hebben-voor-type-info
May 22, 2025
Merged

feat: alert component zou role="status" moeten hebben voor type="info" (#2742)#2828
Robbert merged 8 commits intomainfrom
feat/2742-alert-component-zou-role-status-moeten-hebben-voor-type-info

Conversation

@eslook
Copy link
Copy Markdown
Contributor

@eslook eslook commented May 21, 2025

Closes #2742

#2742)

Closes #2742

- Content voor documentatie genomen uit https://nldesignsystem.nl/richtlijnen/formulieren/status/screenreaders/.
- Alert is beschikbaar in CSS, React en Web Component. React en Web Component zijn gelijk getrokken. CSS vereiste geen wijziging.
- Stories zijn geupdate en gelijkgetrokken.
- Tests zijn niet beschikbaar voor de Alert. Hier maak ik een nieuw issue voor aan.
@eslook eslook requested a review from Robbert May 21, 2025 13:36
@eslook eslook self-assigned this May 21, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utrecht ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 7:25pm

@codecov
Copy link
Copy Markdown

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.40%. Comparing base (3fadfa1) to head (3c12ed0).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
packages/component-library-react/src/Alert.tsx 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2828      +/-   ##
==========================================
- Coverage   90.51%   90.40%   -0.12%     
==========================================
  Files         194      194              
  Lines        1687     1698      +11     
  Branches      367      369       +2     
==========================================
+ Hits         1527     1535       +8     
+ Misses        156      155       -1     
- Partials        4        8       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TessaViergever
TessaViergever previously approved these changes May 21, 2025
Comment thread packages/storybook-web-component/src/Alert.stories.tsx Outdated
Comment thread packages/web-component-library-stencil/src/components/alert.tsx Outdated
Comment thread packages/storybook-react/src/stories/Alert.stories.tsx Outdated
Comment thread components/alert/docs/technology-html.nl.md Outdated
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
36.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Comment thread packages/component-library-react/src/Alert.tsx
@Robbert Robbert enabled auto-merge (rebase) May 22, 2025 08:26
@Robbert Robbert merged commit 85ed6c0 into main May 22, 2025
14 of 17 checks passed
@Robbert Robbert deleted the feat/2742-alert-component-zou-role-status-moeten-hebben-voor-type-info branch May 22, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alert component zou role="status" moeten hebben voor type="info"

3 participants