Update plugin.xml for 2017.1 compatibility #93
Update plugin.xml for 2017.1 compatibility #93achinault wants to merge 1 commit intonnmatveev:masterfrom
Conversation
Make it be compatible to 2017.1
|
You just incremented version, did it help? As far as I understand this plugin uses some deprecated APIs, that were removed in release 2017.1. I am just curious how JetBrains marks old plugins as "incompatible" with new IDE releases, because plugin.xml for this plugin does not have upper bound in |
|
Yep, it got it running on at least my machine(I compiled with the changes and manually installed). I did notice some deprecated warnings but it is out of my scope at the moment for me to try to tackle those. AFAIK It has more to do with recompiling with 2017.1 than anything else, and if he was to submit the recompiled version it would need a new version number(6 seemed as good a number as any). Maybe 5.11 would be preferred? |
|
I think your change did not solve an issue, as it was solved before. Probably @tcripps can make a build and upload it to the plugin repository - then problem will be fixed. However, as an author of https://plugins.jetbrains.com/plugin/8277-protobuf-support, I would like to ask to go in different direction. In comparison to this plugin, I have much better parser, and in general code is easier to extend. There are quite a few features that are missing in my plugin, but present in this one. I would gladly accept PRs for adding missing stuff. |
Make the plugin compatible with 2017.1 by recompiling with a incremented version number, would probably also require updating associated documentation.