Skip to content

Feat add code and http code to most errors#686

Merged
GrosSacASac merged 4 commits intomasterfrom
feat-add-code-and-httpCode-to-most-errors
Feb 16, 2021
Merged

Feat add code and http code to most errors#686
GrosSacASac merged 4 commits intomasterfrom
feat-add-code-and-httpCode-to-most-errors

Conversation

@GrosSacASac
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/FormidableError.js
@lmammino
Copy link
Copy Markdown

Left some minor comments regarding how to encode errors. I really like this new feature btw :)

@GrosSacASac GrosSacASac merged commit 8a74c8a into master Feb 16, 2021
@GrosSacASac GrosSacASac deleted the feat-add-code-and-httpCode-to-most-errors branch February 16, 2021 19:02
@tunnckoCore
Copy link
Copy Markdown
Member

I like this too! Good job.

Minor thing is that I would like more the internal codes to be hardcoded and maybe start from 1000, not from zero.

@GrosSacASac
Copy link
Copy Markdown
Contributor Author

done cd9edd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants