File size fix#791
Merged
GrosSacASac merged 12 commits intomasterfrom Dec 9, 2021
Merged
Conversation
and _fileSize into _totalFileSize
…file is not empty
…leSize if the default minFileSize is 1 then allowEmptyFiles was defacto false
Contributor
Author
|
This would be a breaking change so version 4.0.0 |
Contributor
Author
|
I am going to test this for a week |
Contributor
Author
|
Made it a non breaking change by changing the new defaults |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #607
@mlorthios @kmorte review and try this branch