Skip to content

ansible: add lib as application/octet-stream type#3195

Merged
richardlau merged 1 commit intonodejs:mainfrom
richardlau:mime
Mar 7, 2023
Merged

ansible: add lib as application/octet-stream type#3195
richardlau merged 1 commit intonodejs:mainfrom
richardlau:mime

Conversation

@richardlau
Copy link
Copy Markdown
Member

Serve .lib files with application/octet-stream content-type.

Refs: #3194

Serve `.lib` files with `application/octet-stream` content-type.

Refs: nodejs#3194
@nschonni
Copy link
Copy Markdown
Member

Was going to ask if the exe needed to be added, but looks like it's part of the default set https://github.com/nginx/nginx/blob/master/conf/mime.types

@nschonni
Copy link
Copy Markdown
Member

The only other one that might be missing is https://www.iana.org/assignments/media-types/text/tab-separated-values for the .tab files. Don't think that has any functional change like this change actually does

@richardlau
Copy link
Copy Markdown
Member Author

Forgot to mention that I have already deployed the change in this PR on our two servers.

The only other one that might be missing is https://www.iana.org/assignments/media-types/text/tab-separated-values for the .tab files. Don't think that has any functional change like this change actually does

I'm inclined for now to leave that unless someone runs into a problem with the .tab files.

@richardlau richardlau merged commit b36beec into nodejs:main Mar 7, 2023
@richardlau richardlau deleted the mime branch March 7, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants