This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Closed
Conversation
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit seebees/node-1@6f679ec has the following error(s):
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
The tab complete for Arrays will include any integer indexes. This is suboptimal because obj.21 is not valid syntax and a large array will contain a very cluttered list.
Member
|
Sigh.. 2013 and it looks like this was never reviewed. Just tested the patch against v0.12 and master and it |
Member
|
Closing in favor of alternate: #25819 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tab complete for Arrays will
include any integer indexes. This is
suboptimal because obj.21 is not
valid syntax and a large array will
contain a very cluttered list.
@bnoordhuis RE: #5734. Ask and you shall receive. 2 months later, and perhaps not what you were looking for, but still, you've got to be impressed.
Note: The test should pass, but when I run it with
assert.equal(false, true)here it still passes. I don't think that has anything to do with my change though.