Conversation
response.finished
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit liveinjs/node@fb94876 has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
|
Hmm... unfortunately it doesn't look like this one was ever reviewed. @liveinjs , thank you for submitting this, sorry it's taken so long for someone to look at it. There are a couple of grammatical issues that should be addressed before it's landed tho; and we should verify that the |
|
I'm not 100% sure. Given that it's not underscored, it seems like it should be documented. If we want to document it, this needs a bit of cleanup. |
|
Agree w/ @cjihrig |
|
New cleaned up PR opened. Closing this here. |
response.finished