Wrong legacy API parameter caused by typo in _http_agent.js

[asukakenji]

At https://github.com/nodejs/node/blob/master/lib/_http_agent.js#L114:

The line should read:

      localAddress: arguments[3]

instead of:

      path: arguments[3]

The localAddress parameter was added to the addRequest() function in lib/http.js since 1e9bcf2#diff-1c0f1c434b17b7f8795d44a51a14320a.

The function was then refactored into _http_agent.js at 12cd133.

However, the localAddress parameter was mistaken to be path during the refactoring. Below are some evidences showing that the parameter should be localAddress.

Here is the current code in master:

• https://github.com/nodejs/node/blob/master/lib/_http_agent.js#L108,L118

Here is how the options object is used. It clearly expects localAddress:

• https://github.com/nodejs/node/blob/master/lib/_http_agent.js#L93,L106

Here is the code in an old release (v0.10.36, which is the version currently used on AWS):

• https://github.com/nodejs/node/blob/v0.10.36-release/lib/http.js#L1264,L1268

These clears shows the format host:port:localAddress:

• https://nodejs.org/api/http.html#http_agent_getname_options
• https://nodejs.org/api/http.html#http_agent_maxsockets
• https://nodejs.org/docs/latest-v0.10.x/api/http.html#http_agent_maxsockets

[evanlucas]

This does appear to be the case. Is this breaking something for you?

[asukakenji]

Yes, of course! If it didn't break anything, why did I spend my time digging into the code, finding the problem, and issuing a bug report?

[cjihrig]

@asukakenji would you mind opening a PR, including a regression test?

[asukakenji]

Of course I would like to do something to help! But it is my first time doing that, would you please point me to some guide lines? Thanks!

[cjihrig]

Sure thing! Please see https://github.com/nodejs/node/blob/master/CONTRIBUTING.md.