Skip to content

win, doc: document per-drive current working dir #13330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzoz wants to merge 2 commits into from
Closed

win, doc: document per-drive current working dir #13330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
230745c
win, doc: document per-drive current working dir
bzoz May 26, 2017
e655d7e
fixup: nits
bzoz Jun 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ Error: EISDIR: illegal operation on a directory, read
<stack trace.>
```

*Note:* On Windows Node follows the concept of per-drive working directory.
Copy link
Copy Markdown
Member

@richardlau richardlau May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Node.js although it's probably enough to just say Windows follows... as Node.js is not doing anything different from the OS behavior.

This behavior can be observed when using a drive path without backslash, e.g.
Copy link
Copy Markdown
Member

@Trott Trott May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: , -> . and e.g. -> For example,.

`fs.readdirSync('c:\\')` can potentially return different result than
Copy link
Copy Markdown
Member

@Trott Trott May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return different result -> return a different result

`fs.readdirSync('c:')`. For more information see
Copy link
Copy Markdown
Member

@Trott Trott May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, after information

[this MSDN page][MSDN-Rel-Path].

## WHATWG URL object support
<!-- YAML
added: v7.6.0
Expand Down Expand Up @@ -2835,6 +2841,7 @@ The following constants are meant for use with the [`fs.Stats`][] object's
[FS Constants]: #fs_fs_constants_1
[MDN-Date-getTime]: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Date/getTime
[MDN-Date]: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Date
[MSDN-Rel-Path]: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247.aspx#fully_qualified_vs._relative_paths
[Readable Stream]: stream.html#stream_class_stream_readable
[Writable Stream]: stream.html#stream_class_stream_writable
[inode]: https://en.wikipedia.org/wiki/Inode
6 changes: 6 additions & 0 deletions doc/api/path.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ path.posix.basename('/tmp/myfile.html');
// Returns: 'myfile.html'
```

*Note:* On Windows Node follows the concept of per-drive working directory.
This behavior can be observed when using a drive path without backslash, e.g.
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without backslash -> without a backslash

`path.resolve('c:\\')` can potentially return different result than
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return different -> return a different

`path.resolve('c:')`. For more information see [this MSDN page][MSDN-Rel-Path].

## path.basename(path[, ext])
<!-- YAML
added: v0.1.25
Expand Down Expand Up @@ -550,3 +555,4 @@ of the `path` methods.
[`path.posix`]: #path_path_posix
[`path.sep`]: #path_path_sep
[`path.win32`]: #path_path_win32
[MSDN-Rel-Path]: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247.aspx#fully_qualified_vs._relative_paths
⚡