Skip to content

Make test match others in repository #15935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattcan wants to merge 4 commits into from
Closed

Make test match others in repository #15935

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6eacabc
first-pr: make test match other tests
mattcan Oct 6, 2017
8313444
Updated to clearer message
mattcan Oct 25, 2017
00c8b9b
Actually test something
mattcan Oct 25, 2017
a01a962
Fix linting error in test
mattcan Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/addons-napi/test_dataview/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ const buffer = new ArrayBuffer(128);
const template = Reflect.construct(DataView, [buffer]);

const theDataview = test_dataview.CreateDataView(template);
assert.ok(theDataview instanceof DataView,
'The new variable should be of type Dataview');
assert.ok(theDataview instanceof DataView);
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Oct 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to include the actual instanceof value in the error message here instead of just removing the message.

Copy link
Copy Markdown
Member

@Trott Trott Oct 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of theDataView instanceof DataView will reliably be true or false and thus false if this fails. What might be useful is displaying the value of theDataView so it can be obvious why that failed. If theDataView is undefined rather than some kind of complex object, that's useful info.

Copy link
Copy Markdown
Member

@joyeecheung joyeecheung Oct 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the message to

`Expect ${theDataview} to be a Dataview`

like what @Trott suggested?

⚡