lib: fix JS linter#22175
Closed
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-fix-lint
Closed
lib: fix JS linter#22175maclover7 wants to merge 1 commit intonodejs:masterfrom maclover7:jm-fix-lint
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-fix-lint
Conversation
Not sure why CI (and `make -j8 test` at the time of landing) showed this as being OK, but `make lint-js` is failing now.
nodejs-github-bot
added
the
dgram
Contributor
Author
|
Collaborators, feel free to 👍 this comment to fast track (need to step away from the computer for a pre-scheduled thing, but if this gets enough approvals, don't wait for me to land this :)) |
devsnek
approved these changes
Aug 7, 2018
tniessen
approved these changes
Aug 7, 2018
jasnell
approved these changes
Aug 7, 2018
Fishrock123
approved these changes
Aug 7, 2018
Contributor
|
I think the commit message should be tweaked a bit to describe what is really being changed ( |
cjihrig
approved these changes
Aug 7, 2018
1 task
Member
lpinca
approved these changes
Aug 7, 2018
Member
|
Redo linuxone CI: https://ci.nodejs.org/job/node-test-commit-linuxone/3637/ |
jasnell
pushed a commit
that referenced
this pull request
Aug 7, 2018
Not sure why CI (and `make -j8 test` at the time of landing) showed this as being OK, but `make lint-js` is failing now. PR-URL: #22175 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in e2ea82b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why CI (and
make -j8 testat the time of landing) showed thisas being OK, but
make lint-jsis failing now.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes