Closed
Conversation
This updates all sources in deps/openssl/openssl with openssl-1.1.0j.
This is a floating patch against OpenSSL-1.1.0 to generate asm files with Makefile rules and it is to be submitted to the upstream. Fixes: nodejs#4270 PR-URL: nodejs#19794 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
`cd deps/openssl/config; make` updates all archs dependant files.
Collaborator
|
@sam-github sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
the
openssl
Contributor
Author
Contributor
Author
|
@nodejs/buffer What triggers "Sadly..." messages like #24523 (comment) ? Is it something I did, or just ephemeral build infrastructure failure? |
Contributor
Author
|
@nodejs/crypto PTAL |
Member
Nothing you did. The bot needs its Jenkins API token regenerated: nodejs/github-bot#201 |
shigeki
approved these changes
Nov 21, 2018
Contributor
shigeki
left a comment
shigeki
left a comment
There was a problem hiding this comment.
Thanks for fixing the upgrade document, too.
danbev
approved these changes
Nov 21, 2018
rvagg
approved these changes
Nov 22, 2018
Contributor
Author
|
Landed in 33a25b2...160ac0f |
sam-github
added a commit
that referenced
this pull request
Nov 22, 2018
This updates all sources in deps/openssl/openssl with openssl-1.1.0j. PR-URL: #24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
sam-github
pushed a commit
that referenced
this pull request
Nov 22, 2018
This is a floating patch against OpenSSL-1.1.0 to generate asm files with Makefile rules and it is to be submitted to the upstream. Fixes: #4270 PR-URL: #19794 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
sam-github
added a commit
that referenced
this pull request
Nov 22, 2018
`cd deps/openssl/config; make` updates all archs dependant files. PR-URL: #24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
sam-github
added a commit
that referenced
this pull request
Nov 22, 2018
PR-URL: #24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Contributor
Author
|
FYI I just checked, and this lands clean on v11.x-staging and v10.x-staging. |
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
This updates all sources in deps/openssl/openssl with openssl-1.1.0j. PR-URL: #24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
This is a floating patch against OpenSSL-1.1.0 to generate asm files with Makefile rules and it is to be submitted to the upstream. Fixes: #4270 PR-URL: #19794 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
`cd deps/openssl/config; make` updates all archs dependant files. PR-URL: #24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
PR-URL: #24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This updates all sources in deps/openssl/openssl with openssl-1.1.0j. PR-URL: nodejs#24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This is a floating patch against OpenSSL-1.1.0 to generate asm files with Makefile rules and it is to be submitted to the upstream. Fixes: nodejs#4270 PR-URL: nodejs#19794 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs#24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
`cd deps/openssl/config; make` updates all archs dependant files. PR-URL: nodejs#24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24523 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #24370
make -j4 test(UNIX), orvcbuild test(Windows) passes