Skip to content

test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js #46855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Mar 18, 2023
Merged

test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js #46855

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0e39c6
test: reduce flakiness of test-http-remove-header-stays-removed.js
debadree25 Feb 27, 2023
8a34390
Update test/parallel/test-http-remove-header-stays-removed.js
debadree25 Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions test/parallel/test-http-remove-header-stays-removed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');

const http = require('http');
Expand Down Expand Up @@ -54,13 +54,14 @@ server.listen(0, function() {
res.setEncoding('ascii');
res.on('data', function(chunk) {
response += chunk;
if (response?.toString() === 'beep boop\n') {
Comment thread
debadree25 marked this conversation as resolved.
Outdated
setTimeout(function() {
// The socket should be closed immediately, with no keep-alive, because
// no content-length or transfer-encoding are used:
assert.strictEqual(res.socket.closed, true);
server.close();
}, common.platformTimeout(15));
}
});

setTimeout(function() {
// The socket should be closed immediately, with no keep-alive, because
// no content-length or transfer-encoding are used:
assert.strictEqual(res.socket.closed, true);
server.close();
}, 10);
});
});
⚡