Skip to content

Optimize Memory Usage by Hoisting Function in For Loop 💽 #51242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 4 commits into from
Dec 23, 2023
Merged

Optimize Memory Usage by Hoisting Function in For Loop 💽 #51242

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36c5ca9
perf: Reduce memory usage
sanjaiyan-dev Dec 20, 2023
c8ba57d
revert: doubt code
sanjaiyan-dev Dec 20, 2023
1a8ba62
Update lib/internal/per_context/primordials.js
sanjaiyan-dev Dec 20, 2023
c72264c
Update lib/internal/per_context/primordials.js
sanjaiyan-dev Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/internal/per_context/primordials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,11 +541,14 @@ primordials.SafePromiseAllReturnVoid = (promises, mapFn) =>
new Promise((resolve, reject) => {
let pendingPromises = promises.length;
if (pendingPromises === 0) resolve();
const onPromiseSettled = () => {
Comment thread
sanjaiyan-dev marked this conversation as resolved.
Outdated
if (--pendingPromises === 0) {
resolve();
}
};
for (let i = 0; i < promises.length; i++) {
const promise = mapFn != null ? mapFn(promises[i], i) : promises[i];
PromisePrototypeThen(PromiseResolve(promise), () => {
if (--pendingPromises === 0) resolve();
}, reject);
PromisePrototypeThen(PromiseResolve(promise), onPromiseSettled, reject);
Comment thread
sanjaiyan-dev marked this conversation as resolved.
Outdated
}
});

Expand Down
⚡