Skip to content

build: print Running XYZ linter... for py and yml #54386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Sep 18, 2024
Merged

build: print Running XYZ linter... for py and yml #54386

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d776a8c
build: print `Running XYZ linter...` for py and yml
avivkeller Aug 14, 2024
6560d5d
Update Makefile
avivkeller Aug 14, 2024
e8f3a23
use tabs rather than spaces
avivkeller Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,7 +1536,7 @@ lint-py-build:
ifneq ("","$(wildcard tools/pip/site-packages/ruff)")
# Lint the Python code with ruff.
lint-py:
tools/pip/site-packages/bin/ruff --version
$(info Running Python linter...)
tools/pip/site-packages/bin/ruff check .
else
lint-py:
Expand All @@ -1556,6 +1556,7 @@ lint-yaml-build:
# Lints the YAML files with yamllint.
lint-yaml:
@if [ -d "tools/pip/site-packages/yamllint" ]; then \
$(info Running YAML linter...) \
PYTHONPATH=tools/pip $(PYTHON) -m yamllint .; \
else \
echo 'YAML linting with yamllint is not available'; \
Expand Down
⚡