Skip to content

repl: runtime deprecate instantiating without new#54869

Merged
nodejs-github-bot merged 6 commits intonodejs:mainfrom
avivkeller:repl-deprecate-2
Nov 7, 2024
Merged

repl: runtime deprecate instantiating without new#54869
nodejs-github-bot merged 6 commits intonodejs:mainfrom
avivkeller:repl-deprecate-2

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Sep 9, 2024

Followup #54842

This PR runtime-deprecates instantiating the REPL classes without the new keyword.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig left review comments

@aduh95 aduh95 aduh95 left review comments

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. repl Issues and PRs related to the REPL subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@avivkeller @jasnell @benjamingr @anonrig @mcollina @nodejs-github-bot @aduh95 @JakobJingleheimer @LiviaMedeiros
⚡