Skip to content

test: deflake test/pummel/test-timers.js #55098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Sep 27, 2024
Merged

test: deflake test/pummel/test-timers.js #55098

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c7d586
test: deflake test/pummel/test-timers.js
jakecastelli Sep 24, 2024
aef35bc
fixup! remove unnecessary check
jakecastelli Sep 24, 2024
d9c53b0
fixup! remove more checks
jakecastelli Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/pummel/test-timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const WINDOW = 200; // Why does this need to be so big?
assert.ok(diff > 0);
console.error(`diff: ${diff}`);

assert.ok(1000 <= diff && diff < 1000 + WINDOW);
assert.ok(Math.abs(diff - 1000) < WINDOW);
}), 1000);
}

Expand All @@ -61,7 +61,7 @@ const WINDOW = 200; // Why does this need to be so big?

const t = interval_count * 1000;

assert.ok(t <= diff && diff < t + (WINDOW * interval_count));
assert.ok(Math.abs(diff - t) < WINDOW && diff < t + (WINDOW * interval_count));
Comment thread
jakecastelli marked this conversation as resolved.
Outdated

assert.ok(interval_count <= 3, `interval_count: ${interval_count}`);
if (interval_count === 3)
Expand Down
⚡