Skip to content

process: fix process.features.typescript when Amaro is unavailable #55323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Oct 11, 2024
Merged

process: fix process.features.typescript when Amaro is unavailable #55323

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94b422a
process: fix `process.features.typescript` when Amaro is unavailable
aduh95 Oct 8, 2024
dbf4cbe
fixup! process: fix `process.features.typescript` when Amaro is unava…
aduh95 Oct 9, 2024
60dce1f
fixup! process: fix `process.features.typescript` when Amaro is unava…
aduh95 Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/bootstrap/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ ObjectDefineProperty(process, 'features', {
const { emitWarning, emitWarningSync } = require('internal/process/warning');
const { getOptionValue } = require('internal/options');

let kTypeStrippingMode = null;
let kTypeStrippingMode = process.config.variables.node_use_amaro ? null : false;
// This must be a getter, as getOptionValue does not work
// before bootstrapping.
ObjectDefineProperty(process.features, 'typescript', {
Expand Down
4 changes: 2 additions & 2 deletions test/es-module/test-typescript.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ test('expect process.features.typescript to be \'strip\' when --experimental-str
]);

strictEqual(result.stderr, '');
strictEqual(result.stdout, 'strip\n');
strictEqual(result.stdout, process.config.variables.node_use_amaro ? 'strip\n' : 'false\n');
Comment thread
aduh95 marked this conversation as resolved.
Outdated
strictEqual(result.code, 0);
});

Expand All @@ -373,7 +373,7 @@ test('expect process.features.typescript to be \'transform\' when --experimental
]);

strictEqual(result.stderr, '');
strictEqual(result.stdout, 'transform\n');
strictEqual(result.stdout, process.config.variables.node_use_amaro ? 'transform\n' : 'false\n');
strictEqual(result.code, 0);
});

Expand Down
⚡