Skip to content

util: fix Latin1 decoding to return string output #56222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Dec 14, 2024
Merged

util: fix Latin1 decoding to return string output #56222

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
41bd55f
util: fix Latin1 decoding to return string output
Dec 11, 2024
3333f75
test: add validation for DecodeLatin1 string output
Dec 11, 2024
88a6182
lint
Dec 11, 2024
19da291
test: add validation for TextDecoder windows-1252 decoding
Dec 11, 2024
a83c409
test: skip TextDecoder test if Intl support is missing
Dec 11, 2024
d9e8b1a
Update test/parallel/test-util-text-decoder.js
mertcanaltin Dec 11, 2024
e8cf59a
lint fix
Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/parallel/test-util-text-decoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
'use strict';

require('../common');
const common = require('../common');

const test = require('node:test');
const assert = require('node:assert');

test('TextDecoder correctly decodes windows-1252 encoded data', (t) => {
if (!common.hasIntl) {
common.skip('missing Intl');
}
Comment thread
aduh95 marked this conversation as resolved.
Outdated

const latin1Bytes = new Uint8Array([0xc1, 0xe9, 0xf3]);

const expectedString = 'Áéó';
Expand Down
⚡