Skip to content

src: lock the isolate properly in IsolateData destructor #57031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Feb 15, 2025
Merged

src: lock the isolate properly in IsolateData destructor #57031

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a597b98
src: lock the isolate properly in IsolateData destructor
joyeecheung Feb 13, 2025
7bfd05c
test: use v8::Locker to lock isolates properly in cctest
joyeecheung Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,7 @@ IsolateData::IsolateData(Isolate* isolate,

IsolateData::~IsolateData() {
if (cpp_heap_ != nullptr) {
v8::Locker locker(isolate_);
// The CppHeap must be detached before being terminated.
isolate_->DetachCppHeap();
cpp_heap_->Terminate();
Expand Down
⚡