lib: use Object.freeze to avoid defensive cloning in SourceMap#62830
Open
watilde wants to merge 2 commits intonodejs:mainfrom
Open
lib: use Object.freeze to avoid defensive cloning in SourceMap#62830watilde wants to merge 2 commits intonodejs:mainfrom
watilde wants to merge 2 commits intonodejs:mainfrom
Conversation
watilde
force-pushed
the
fixes-memory-sourcemap
branch
from
3b8cc82 to
73ffd8a
Compare
watilde
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62830 +/- ##
==========================================
+ Coverage 89.61% 89.62% +0.01%
==========================================
Files 706 706
Lines 219203 219201 -2
Branches 41995 41990 -5
==========================================
+ Hits 196445 196468 +23
+ Misses 14663 14638 -25
Partials 8095 8095
🚀 New features to boost your workflow:
|
legendecas
added
semver-major
legendecas
reviewed
Apr 20, 2026
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
Would you mind adding a note on https://github.com/nodejs/node/blob/main/doc/api/module.md#sourcemappayload that the returned payload is frozen? Thanks!
legendecas
reviewed
Apr 22, 2026
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
Would you mind fixing the linter complaints? Thanks
| generated code. | ||
|
|
||
| #### `sourceMap.payload` | ||
|
|
Member
There was a problem hiding this comment.
Worth to add a change section:
Suggested change
| <!-- YAML | |
| changes: | |
| - version: REPLACEME | |
| pr-url: https://github.com/nodejs/node/pull/62830 | |
| description: The object is frozen. | |
Member
There was a problem hiding this comment.
This was marked as resolved, but it seems like this was not applied.
watilde
force-pushed
the
fixes-memory-sourcemap
branch
from
bd11c1e to
f5cc42f
Compare
watilde
force-pushed
the
fixes-memory-sourcemap
branch
from
f5cc42f to
f493f69
Compare
Member
Author
|
Fix, rebase and make the commit Verified. |
legendecas
added
the
commit-queue-squash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.