feat: moved get-involved and guides content#6172
Merged
Conversation
ovflowd
added
content
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
Bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Member
Author
|
cc @nodejs/tsc as this is a relatively big "content-drift" on the Website. Note that this change does not remove content; Just reallocate them to different places to properly start to match the Website Redesign. |
Member
Author
|
Note: All existing links will still work and properly redirect. This PR should not break existing links and user experience. |
Contributor
Unit Test Coverage Report
Unit Test Report
|
github-actions
Bot
removed
the
github_actions:pull-request
marco-ippolito
approved these changes
Dec 2, 2023
himself65
approved these changes
Dec 2, 2023
AugustinMauroy
approved these changes
Dec 2, 2023
bmuenzenmeyer
approved these changes
Dec 3, 2023
Contributor
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
one question about the next.rewrites.js logic - functionally this looks good
aymen94
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request is another push towards the Navigation that will exist on the Node.js Website Redesign.
This Pull Request moves all
/get-involvedpages unto/about/get-involvedand it moves the/docs/guidesinto a dedicated/guidestop-level navigation.Other Related Changes
/:locale/docswill now redirect tohttps://nodejs.org/docs/latest/api//:locale/docs/guideswill now redirect to/:locale/guides/:locale/docs/es6will redirect to the ES6 learn page of the same contenthttps://nodejs.org/docs/latest/api/Validation