Fetch

[ronag]

Things to help out with to bring fetch out of experimental status.

• Types
• Docs (Fetch #915 (comment))
• Look for TODOs in https://github.com/nodejs/undici/blob/main/lib/api/api-fetch.js
• Headers and spec comments + fixes (Add spec comments to Header class #933)
• Error types (Ensure we only throw Error types defined in spec #931)
• Review spec compliance https://fetch.spec.whatwg.org/
• Blob.type (Blob should have response content type #925)
• data: uri (Add support for data uri's in fetch #929)
• Improve httpNetworkFetch spec compliance.
• FormData (FormData #930)
• highWaterMark browser compatibility (Fetch highWaterMark #923)
• Enable/fix disabled test in https://github.com/nodejs/undici/tree/node-fetch/test/node-fetch and try to uncomment.
• WebSocket (WebSocket #932)
• Fix Request.clone
• Fix Response.clone ( Fix Request.clone #945)

Tests

• Improve coverage
• Port tests from WPT (https://github.com/web-platform-tests/wpt/tree/master/fetch). See also Implement using web-streams-polyfill whatwg-stream#3.
• Port tests from node-fetch (fix: implement fetch per spec #928)
• Port tests from undici-fetch (Port tests from undici-fetch #926)

Response

https://github.com/nodejs/undici/blob/main/lib/api/api-fetch/index.js#L158
https://github.com/nodejs/undici#parameter-response
https://fetch.spec.whatwg.org/#response-class

• clone() (fix: fetch response is not Readable #921)
• statusText
• Extract, expose Response class (fix: implement fetch per spec #928)
• Document Response class

Request

• Extract, expose Request class (fix: implement fetch per spec #928)
• Document Request class

Headers

• Expose Headers class (fix: implement fetch per spec #928)
• Document Headers class

Spec

#958

• httpRedirectFetch
• setRequestReferrerPolicyOnRedirect
• httpFetch
• httpNetworkOrCacheFetch
• httpNetworkFetch
• fetchFinale
• finalizeResponse
• mainFetch
• fetching
• finalizeAndReportTiming
• fetch
• markResourceTiming

[Ethan-Arrowood]

Looks great! I'll take a deeper look at this when I can and try to pick something up

[ronag]

In regards to documentation should we document it or just refer to the spec/MDN ofc with differences/limitations mentioned? @mcollina @szmarczak @Ethan-Arrowood

[mcollina]

I think we should be ok in referring to MDN and documenting the difference/limitations... at least for now.

[trivikr]

I landed on this issue after reading about questions on undici fetch web compliance in nodejs/node#41749 (review)

I think it would be helpful if a link to web compliance summary is provided in README at https://github.com/nodejs/undici#undicifetchinput-init-promise

It would be up to undici team on how they would like to track the web compliance. I would recommend creating a milestone similar to https://github.com/nodejs/undici/milestone/5 where all compliance related issues can be added to. WDYT?

cc @ronag @mcollina

[trivikr]

I landed on this issue after reading about questions on undici fetch web compliance in nodejs/node#41749 (review)

As part of naming and compliance related questions, @targos @benjamingr asked Deno team summarized in nodejs/node#41749 (comment)

They have documented deviations in Deno fetch implementation from web spec in their docs at https://deno.land/manual@v1.18.1/runtime/web_platform_apis#spec-deviations

[targos]

I did not ask Deno team.

[trivikr]

I did not ask Deno team.

My bad, it was @benjamingr who created an issue with Deno team. I've edited my comment.