Skip to content

feat: accept third-party Blobs in FormData#1099

Merged
mcollina merged 3 commits intonodejs:mainfrom
wojpawlik:third-party-blob
Nov 17, 2021
Merged

feat: accept third-party Blobs in FormData#1099
mcollina merged 3 commits intonodejs:mainfrom
wojpawlik:third-party-blob

Conversation

@wojpawlik
Copy link
Copy Markdown
Contributor

Works around nodejs/node#37340.
Advances telegraf/telegraf#1502.
Closes #930.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 16, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.78%. Comparing base (64d07c3) to head (65997b3).
⚠️ Report is 2241 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          39       39           
  Lines        3780     3781    +1     
=======================================
+ Hits         3583     3584    +1     
  Misses        197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Can you please add a unit test?

Comment thread lib/fetch/util.js Outdated
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 46eff3f into nodejs:main Nov 17, 2021
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FormData

4 participants