feat: capture error stack traces#1619
Merged
mcollina merged 3 commits intonodejs:mainfrom Aug 27, 2022
Merged
Conversation
Contributor
Author
|
@mcollina Please review 🙂 |
mcollina
requested changes
Aug 26, 2022
Contributor
Author
|
Oops, looks like something broke in the tests @mcollina any clues as to why this fails on node 14? my guess is that I am testing What's the difference between |
Member
|
@sidwebworks move the test file to the test/fetch folder |
Codecov Report
@@ Coverage Diff @@
## main #1619 +/- ##
=======================================
Coverage 94.92% 94.93%
=======================================
Files 50 50
Lines 4792 4798 +6
=======================================
+ Hits 4549 4555 +6
Misses 243 243
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
KhafraDev
approved these changes
Aug 26, 2022
Contributor
Author
|
@KhafraDev Thank you for the help |
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1599
Checklist: