fix: expose EventSource for nodejs#2645
Merged
mcollina merged 1 commit intonodejs:mainfrom Feb 5, 2024
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would actually recommend to rename index-fetch.js to index-node.js as it is not only exposing fetch but also Websocket and now EventSource.
But this would mean that we also have to patch the dependency updater for undici in nodejs
This is afaik blocking nodejs/node#51575
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status