Merged
Conversation
ronag
force-pushed
the
proxy-example
branch
from
0a0364d to
5336010
Compare
ronag
commented
Sep 19, 2020
|
|
||
| headers = getResponseHeaders(headers) | ||
|
|
||
| // TODO (perf): res.writeHead should support Array and/or string. |
Member
Author
There was a problem hiding this comment.
@mcollina: It would be nice if core writeHead supported the key/value array directly without having to convert it into an object. Alternatively a string.
ronag
force-pushed
the
proxy-example
branch
12 times, most recently
from
319cc3d to
c3218b3
Compare
mcollina
reviewed
Sep 20, 2020
ronag
commented
Sep 20, 2020
ronag
force-pushed
the
proxy-example
branch
8 times, most recently
from
a5ccaa6 to
7419561
Compare
ronag
force-pushed
the
proxy-example
branch
from
58c24c2 to
f913231
Compare
ronag
force-pushed
the
proxy-example
branch
from
1702724 to
91ddb9d
Compare
ronag
force-pushed
the
proxy-example
branch
from
91ddb9d to
cb32506
Compare
Member
Author
|
@mcollina: This is starting to feel pretty solid. I think for an example it is good. If we want to include it as a helper I believe we need to in addition to test also add some hooks for modifying req/res headers and maybe also the response body as well as options to disable forwarded. Not sure if informational headers and trailers are a must. |
ronag
force-pushed
the
proxy-example
branch
2 times, most recently
from
91a2faf to
51fcacc
Compare
ronag
commented
Sep 20, 2020
ronag
commented
Sep 20, 2020
ronag
force-pushed
the
proxy-example
branch
6 times, most recently
from
370eb39 to
7ca6252
Compare
ronag
force-pushed
the
proxy-example
branch
from
7ca6252 to
b56794f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.