fix: implement fetch per spec

.github/workflows/nodejs.yml

@@ -20,25 +20,34 @@ jobs:
     - uses: actions/checkout@v2
 
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
+      uses: actions/setup-node@v2
       with:
         node-version: ${{ matrix.node-version }}
 
     - name: Install
       run: |
         npm install
 
-    - name: Unit test (no coverage)
+    - name: Test Tap
       run: |
-        npm test
+        npm run test:tap
 
-    - name: Unit test (coverage)
+    - name: Test Jest
       run: |
-        npm run coverage:ci
+        npm run test:jest
+
+    # How to run only for Node 16+?
+    # - name: Test node-fetch
+    #   run: |
+    #     npm run test:node-fetch
 
-    - name: Test types
+    - name: Test Types
       run: |
         npm run test:typescript
 
-    - name: Coverage report
+    - name: Coverage
+      run: |
+        npm run coverage:ci
+
+    - name: Coverage Report
       uses: codecov/codecov-action@v1

README.md

@@ -157,7 +157,7 @@ See [Dispatcher.connect](docs/api/Dispatcher.md#dispatcherconnect) for more deta
 
 https://fetch.spec.whatwg.org/
 
-### `undici.fetch([url, options]): Promise`
+### `undici.fetch(input[, init]): Promise`
 
 Implements [fetch](https://fetch.spec.whatwg.org/).
 
@@ -167,8 +167,8 @@ This is [experimental](https://nodejs.org/api/documentation.html#documentation_s
 
 Arguments:
 
-* **url** `string | URL | object`
-* **options** `RequestInit`
+* **input** `string | Request`
+* **init** `RequestInit`
 
 Returns: `Promise<Response>`
 

docs/api/Dispatcher.md

@@ -307,8 +307,6 @@ client.dispatch({
 
 ### `Dispatcher.fetch(options)`
 
-Implements [fetch](https://fetch.spec.whatwg.org/).
-
 Only supported on Node 16+.
 
 This is [experimental](https://nodejs.org/api/documentation.html#documentation_stability_index) and is not yet fully compliant the Fetch Standard. We plan to ship breaking changes to this feature until it is out of experimental.

index.js

@@ -84,7 +84,16 @@ function makeDispatcher (fn) {
 module.exports.setGlobalDispatcher = setGlobalDispatcher
 module.exports.getGlobalDispatcher = getGlobalDispatcher
 
-module.exports.fetch = makeDispatcher(api.fetch)
+if (api.fetch) {
+  module.exports.fetch = async function fetch (resource, init) {
+    const dispatcher = getGlobalDispatcher()
+    return api.fetch.call(dispatcher, resource, init)
+  }
+  module.exports.Headers = api.fetch.Headers
+  module.exports.Response = api.fetch.Response
+  module.exports.Request = api.fetch.Request
+}
+
 module.exports.request = makeDispatcher(api.request)
 module.exports.stream = makeDispatcher(api.stream)
 module.exports.pipeline = makeDispatcher(api.pipeline)

lib/api/api-fetch/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2020 Ethan Arrowood
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.