Conversation
Simplify the signature of uvwasi_fd_table_init() to make it easier to configure stdio.
This commit refactors the code that configures the stdio descriptors. Instead of setting them up in a loop, use a function. This will make it simpler to add the stdio as configurable options.
This commit requires the stdio file descriptors to be explicitly defined. This allows embedders to run multiple WASI applications in the same process (assuming they also monkey patch the uvwasi_proc_exit() functionality to not force the process to exit).
Windows doesn't seem to like the use of stdin, stdout, or stderr as struct members.
addaleax
approved these changes
Mar 14, 2020
Collaborator
Author
|
Tested these changes in the Node test suite (on macOS) and everything seems fine. Thanks for the review Anna. |
This was referenced Mar 14, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds options to
uvwasi_init()to allow setting the stdio file descriptors. This will allow embedders like Node.js to run multiple WASI applications in the same process without sharing stdio.Unfortunately, Windows doesn't seem to like the use of the names
stdin,stdout, andstderras struct members, which is why I went within,out, anderr.