Next release snap#3635
Merged
Merged
Conversation
* docs: node: point at telnet module now See 8d091c4 * Fix links Co-authored-by: Marcel Stör <marcelstoer@users.noreply.github.com>
Do not change the URL to artifacts that reside inside the `/docs` folder as they are correctly managed by MkDocs. Fixes #3495
This change prevents the shell from erroring out with `$PATH` values that contain e.g. parentheses, as is likely for WSL users.
This is intended to be a more portable abstraction: rather than hard-coding offsets in the macro invocations, it relies on the existence of __builtin_offset and its availability even within inline asm blocks. While here, rename some of the functions involved to hopefully improve clarity
The header files were moved into `include` in the commit https://review.coreboot.org/plugins/gitiles/flashrom/+/87d7b110d6ed6d4ef0b61e777f2fee3c10808f0b
* Allow configuration of debugOutput to be performed * don't send to own IP or update own data * Use same socket to send and receive. Avoid problems in many opened and closed sockets to send * Add callback for REMOVEed hosts * Send broascast messages if seedList is empty * Adapt yeelink to new luacheck rules * Fix building of luac.cross for win to win2019 and VS 2019
Adapt https://www.lua.org/work/diffs-lua-5.3.5-lua-5.3.6.html to NodeMCU. Mostly a straight application, but some small tweaks were required and, in lundump.c, some changes were elided and some additional diff reduction applied, as we have heavily diverged from upstream.
Updates old link to ESP8266 product page which referred to a 404 page.
Member
|
Would like to add 1 or 2 pull reques first. |
Member
Author
|
@HHHartmann which ones did you have in mind? |
Member
|
I would suggest these at least:
and maybe this one, but it would need a little bit of love first And of course I'd still like to get this integrated: |
Member
Author
|
The first four seemed like no-brainers. Hence, I felt confident to merge them 😄 As for the last one, I'm completely lost, not my world. |
Member
|
When merging this PR a github workflow should start creating the release note together with attached luac.cross binaries for windows. So give it some time. |
Member
|
found some more changes that hepled me: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was triggered by Gregor's comment at #3633 (comment).
It's been ages since we last snapped something back to the
releasebranch. What we documented at https://github.com/nodemcu/nodemcu-firmware/blob/release/CONTRIBUTING.md#handling-releases is mostly still correct 😄