Minor fixes for better stability#24
Merged
trevnorris merged 4 commits intonode-v20.x-nsolid-v5.xfrom Nov 13, 2023
Merged
Conversation
santigimeno
approved these changes
Nov 10, 2023
The value access needs to be thread safe. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
When the Environment instance associated with the main thread is removed, reset the main_thread_id_. This will make sure calls to GetMainEnvInst() don't return something invalid. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
added a commit
that referenced
this pull request
Nov 13, 2023
If RunCommand succeeds then the callback should always be called. This way everything can be cleaned up properly. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
added a commit
that referenced
this pull request
Nov 13, 2023
As long as env() doesn't return nullptr it is assumed that access to envinst_ is possible. So change the order of cleanup. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
force-pushed
the
trevnorris/minor-fixes
branch
from
94ee9f2 to
550b590
Compare
If RunCommand succeeds then the callback should always be called. This way everything can be cleaned up properly. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
As long as env() doesn't return nullptr it is assumed that access to envinst_ is possible. So change the order of cleanup. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
force-pushed
the
trevnorris/minor-fixes
branch
from
550b590 to
3ec83cd
Compare
trevnorris
added a commit
that referenced
this pull request
Dec 5, 2023
The value access needs to be thread safe. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
added a commit
that referenced
this pull request
Dec 5, 2023
When the Environment instance associated with the main thread is removed, reset the main_thread_id_. This will make sure calls to GetMainEnvInst() don't return something invalid. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
added a commit
that referenced
this pull request
Dec 5, 2023
If RunCommand succeeds then the callback should always be called. This way everything can be cleaned up properly. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
added a commit
that referenced
this pull request
Dec 5, 2023
As long as env() doesn't return nullptr it is assumed that access to envinst_ is possible. So change the order of cleanup. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
added a commit
that referenced
this pull request
Dec 7, 2023
The value access needs to be thread safe. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
added a commit
that referenced
this pull request
Dec 7, 2023
When the Environment instance associated with the main thread is removed, reset the main_thread_id_. This will make sure calls to GetMainEnvInst() don't return something invalid. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
added a commit
that referenced
this pull request
Dec 7, 2023
If RunCommand succeeds then the callback should always be called. This way everything can be cleaned up properly. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
added a commit
that referenced
this pull request
Dec 7, 2023
As long as env() doesn't return nullptr it is assumed that access to envinst_ is possible. So change the order of cleanup. PR-URL: #24 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.