agents: fix OTLPAgent race conditions on cleanup#30
Merged
santigimeno merged 1 commit intonode-v20.x-nsolid-v5.xfrom Nov 30, 2023
Merged
agents: fix OTLPAgent race conditions on cleanup#30santigimeno merged 1 commit intonode-v20.x-nsolid-v5.xfrom
santigimeno merged 1 commit intonode-v20.x-nsolid-v5.xfrom
Conversation
trevnorris
approved these changes
Nov 27, 2023
santigimeno
force-pushed
the
santi/otlp_agent
branch
from
1240e03 to
1a1236e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
exit_lock_out of the class and make it static so we can use it even if the agent has been deleted.Also, make sure we use the
exit_lock_inOTLPAgent::config_msg_cb_.Fixes: #29