noobaa/core: remove global websocket#8514
Merged
aspandey merged 1 commit intonoobaa:masterfrom Nov 10, 2024
Merged
Conversation
aspandey
force-pushed
the
remove_global_websocket
branch
from
a5e0677 to
5de427b
Compare
liranmauda
approved these changes
Nov 10, 2024
In node v22, websocket is enabled by default nodejs/node#51594 This will cause an error on following line when the global.Websocket would be true. const WS = global.WebSocket || require('ws'); global.WebSocket: This will points to Node.js's native WebSocket, which does not include a Server class. require('ws'): The ws package includes both WebSocket and WebSocket.Server, but this fallback is skipped because global.WebSocket is already defined in Node.js v22 Signed-off-by: Ashish Pandey <aspandey@redhat.com>
aspandey
force-pushed
the
remove_global_websocket
branch
from
5de427b to
ee6cf99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep PR for node 22
In node v22, websocket is enabled by default
nodejs/node#51594
This will cause an error on following line when the global.Websocket would be true.
const WS = global.WebSocket || require('ws');
global.WebSocket: This will points to Node.js's native WebSocket, which does not include a Server class.
require('ws'): The ws package includes both WebSocket and WebSocket.Server, but this fallback is skipped because global.WebSocket is already defined in Node.js v22