This repository was archived by the owner on Oct 1, 2018. It is now read-only.
Speed up android initial assets copy#204
Merged
Merged
Conversation
added 2 commits
August 26, 2016 15:19
Androids AssetManager.list method is known to have performance issues. Initial assets copy uses java.util.jar.JarFile to enumerate and extract assets.
Member
|
Nice! Thanks for that! |
Member
|
Can you share some time comparisons on before and after the changes? |
Contributor
Author
|
Sure, and first, thanks for you plugin - it saved me a lot of work ;). In our case (2k+ files in 500+ directories) initial copy took over 70 seconds in emulator and never came back on test devices. With those changes it takes under 5 seconds in emulator and few seconds on test devices. |
Member
|
Awesome, thanks! |
Member
|
Released in v1.5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Androids AssetManager.list method is known to have performance issues, leading to ASSETS_FOLDER_IN_NOT_YET_INSTALLED error in this case.
Initial assets copy uses now java.util.jar.JarFile to enumerate and extract
assets, wich is much faster.