Refactored to use centralized downloader.#40
Conversation
e553c77 to
3b01c28
Compare
|
Thanks for that, will look into it. |
|
I noticed only later that the plugin.xml file would have to be updated with regards to the file deletions I made. I will submit an addendum soon. Is there an intent to add a testing framework and tests? Because we are pretty much in the dark for changes of this nature. I am not sure of the current best practice on cordova plugin testing. |
|
Regarding the Regarding tests: I have that in plans for the future, but how exactly this will and should work - don't know yet. Didn't have much time for investigation. There should be some unit tests for the native side and for the hooks, plus some integration tests. Unit tests for the native should be written by using the platform instruments for that. Tests for hooks and integration - on JS. And we need a way to run all of them from console. With JS tests that's easy - |
Implemented using NSURLSession which can be configured with headers. (In a future PR). Removed now unused network related files.
3b01c28 to
4fe4629
Compare
|
Merged with some cleanup. Thanks! |
|
Thank you @nikDemyankov, I have the PR for allowing headers ready. Will post shortly. Do not hesitate to forward any problems to me. |
|
Cool, thanks! |
Implemented using NSURLSession which can be configured with headers. (In
a future PR).
Removed now unused network related files.
Fixes #36