Free up LazySuite precache while getting tests#1030
Open
rtpg wants to merge 1 commit intonose-devs:masterfrom
Open
Free up LazySuite precache while getting tests#1030rtpg wants to merge 1 commit intonose-devs:masterfrom
rtpg wants to merge 1 commit intonose-devs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LazySuitewill, by default, keep a cache of tests that are being added to it. This cache never gets removed, so when running a very large test suite, older test cases do not get freed, causing memory pressure over the long term.This patch instead removes elements from the cache as they get read. Since the test are supposed to be iterated over just once, I believe this does not change the outward spec of this class, even if internal details have changed.