Use strict-mode compatible octal literals#100
Closed
skeggse wants to merge 1 commit intonpm:latestfrom
skeggse:fix-octal-literals
Closed
Use strict-mode compatible octal literals#100skeggse wants to merge 1 commit intonpm:latestfrom skeggse:fix-octal-literals
skeggse wants to merge 1 commit intonpm:latestfrom
skeggse:fix-octal-literals
Conversation
Author
|
Error: brain is off. This is a dependency. |
antongolub
pushed a commit
to antongolub-forks/npm-cli
that referenced
this pull request
May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you're doing unsupported things like trying to bundle npm's CLI, and are using a bundler that assumes ES6 modules for all source files, then the deprecated octal literals used here are problematic. This PR replaces the deprecated form with the modern octal literal form.