Skip to content

fix: npm link does not respect --no-save #6910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wraithgar merged 10 commits into from
Oct 31, 2023
Merged

fix: npm link does not respect --no-save #6910

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ba16ac4
fix: npm link does not respect --no-save
Santoshraj2 Oct 17, 2023
126a3aa
fix: npm link does not respect --no-save
Santoshraj2 Oct 26, 2023
5abafa1
fix: npm link does not respect --no-save
Santoshraj2 Oct 26, 2023
167533a
New Test Case Added
Santoshraj2 Oct 30, 2023
2bae2e1
New Test Case Added
Santoshraj2 Oct 30, 2023
a427a18
New Test Case Added
Santoshraj2 Oct 30, 2023
8652845
Test Cases Changes For --no-save
Santoshraj2 Oct 30, 2023
7f27dda
Test Cases Changes For --no-save
Santoshraj2 Oct 30, 2023
b832059
issue --no-save fixed
Santoshraj2 Oct 30, 2023
57b8e64
fixup! Update test/lib/commands/link.js
wraithgar Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/commands/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ class Link extends ArboristWorkspaceCmd {
// npm link should not save=true by default unless you're
// using any of --save-dev or other types
const save =
!Boolean(this.npm.config.argv[3] === '--no-save') &&
Comment thread
Santoshraj2 marked this conversation as resolved.
Outdated
Boolean(
this.npm.config.find('save') !== 'default' ||
this.npm.config.get('save-optional') ||
Expand Down
⚡