deps: bump sigstore from 2.2.0 to 3.0.0#7833
Merged
Conversation
bdehamer
commented
Oct 14, 2024
BREAKING CHANGE: Attestations made by this package will no longer validate in npm versions prior to 10.6.0 Signed-off-by: Brian DeHamer <bdehamer@github.com>
90ab6e2 to
df2a6e0
Compare
df2a6e0 to
cfaddff
Compare
Contributor
|
This only updates the pacote dep in one place and not for all package.json that have it as a dep. Do we want to update those as well? |
Member
|
pacote was already updated, this fixes the duping (for pacote at least) that started w/ the last npm 10 release. Once this lands, the only outdated pacote in the tree will be a dev dep under template-oss |
Signed-off-by: Brian DeHamer <bdehamer@github.com>
wraithgar
approved these changes
Oct 15, 2024
Member
|
We also only keep the pacote ref in the cli itself up to date because that version is effectively "pinned" due to the bundled dependencies. The other packages don't need a new version every time we update pacote. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the following dependencies:
@sigstore/tuffrom2.3.4to3.0.0sigstorefrom2.2.0to3.0.0