Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

install/deps: Let git deps w/ lock only match package.json#20390

Closed
iarna wants to merge 3 commits intorelease-nextfrom
6-safe-git-deps
Closed

install/deps: Let git deps w/ lock only match package.json#20390
iarna wants to merge 3 commits intorelease-nextfrom
6-safe-git-deps

Conversation

@iarna
Copy link
Copy Markdown
Contributor

@iarna iarna commented Apr 20, 2018

Previously they would only match if the complete commitid was used. This allows partial matching when no on-disk component is available.

This will need a minor patch to coordinate with #20384

@iarna iarna requested a review from a team as a code owner April 20, 2018 10:37
@zkat zkat changed the base branch from release-next to latest April 20, 2018 17:27
@zkat zkat changed the base branch from latest to release-next April 20, 2018 17:28
@zkat zkat force-pushed the 6-safe-git-deps branch from 9014156 to 042cd4c Compare April 20, 2018 17:28
iarna added 2 commits April 20, 2018 14:30
@iarna @zkat
install/deps: Let git deps w/ lock only match package.json
64ffe0e 
Previously they would only match if the complete commitid was used.  This
allows partial matching when no on-disk component is available.

Fixes: #16839

PR-URL: #20390
Credit: @iarna
Reviewed-By: @zkat
@iarna @zkat
has-modern-meta: Correctly identify git changelings
49c3435 
PR-URL: #20390
Credit: @iarna
Reviewed-By: @zkat
@zkat zkat force-pushed the 6-safe-git-deps branch from 7583ef3 to 49c3435 Compare April 20, 2018 21:31
@iarna iarna force-pushed the 6-safe-git-deps branch from b8777c8 to 7353d36 Compare April 20, 2018 22:28
iarna added a commit that referenced this pull request Apr 20, 2018
@iarna
install/deps: Let git deps w/ lock only match package.json
e4ed976 
Previously they would only match if the complete commitid was used.  This
allows partial matching when no on-disk component is available.

Fixes: #16839

PR-URL: #20390
Credit: @iarna
Reviewed-By: @zkat
iarna added a commit that referenced this pull request Apr 20, 2018
@iarna
has-modern-meta: Correctly identify git changelings
2facb35 
PR-URL: #20390
Credit: @iarna
Reviewed-By: @zkat
iarna added a commit that referenced this pull request Apr 20, 2018
@iarna
inflate-shrinkwrap: For git changelings use version as resolved
9c1eb94 
Credit: @iarna
PR-URL: #20390
Reviewed-By: @zkat
@iarna
Copy link
Copy Markdown
Contributor Author

iarna commented May 3, 2018

This landed starting at e4ed976 in 6.0.0

@iarna iarna closed this May 3, 2018
iarna added a commit that referenced this pull request May 5, 2018
@iarna
install/deps: Let git deps w/ lock only match package.json
268f7ac 
Previously they would only match if the complete commitid was used.  This
allows partial matching when no on-disk component is available.

Fixes: #16839

PR-URL: #20390
Credit: @iarna
Reviewed-By: @zkat
iarna added a commit that referenced this pull request May 5, 2018
@iarna
has-modern-meta: Correctly identify git changelings
5f84ebd 
PR-URL: #20390
Credit: @iarna
Reviewed-By: @zkat
iarna added a commit that referenced this pull request May 5, 2018
@iarna
inflate-shrinkwrap: For git changelings use version as resolved
c12e614 
Credit: @iarna
PR-URL: #20390
Reviewed-By: @zkat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@iarna
⚡