Skip to content

fix: explicitly set package-name for release please workspaces #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukekarrys merged 1 commit into from
Apr 6, 2022
Merged

fix: explicitly set package-name for release please workspaces #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/content/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
{{#if pkgRelPath}}
monorepo-tags: true
path: {{pkgRelPath}}
# name can be removed after this is merged
# https://github.com/google-github-actions/release-please-action/pull/459
package-name: "{{pkgName}}"
{{/if}}
changelog-types: >
[
Expand Down
6 changes: 6 additions & 0 deletions tap-snapshots/test/apply/full-content.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,9 @@ jobs:
release-type: node
monorepo-tags: true
path: workspaces/b
# name can be removed after this is merged
# https://github.com/google-github-actions/release-please-action/pull/459
package-name: "bbb"
changelog-types: >
[
{"type":"feat","section":"Features","hidden":false},
Expand Down Expand Up @@ -1102,6 +1105,9 @@ jobs:
release-type: node
monorepo-tags: true
path: workspaces/a
# name can be removed after this is merged
# https://github.com/google-github-actions/release-please-action/pull/459
package-name: "@name/aaaa"
changelog-types: >
[
{"type":"feat","section":"Features","hidden":false},
Expand Down
⚡