fix: reject leading hyphens#156
Merged
hashtagchris merged 3 commits intomainfrom Dec 18, 2025
Merged
Conversation
hashtagchris
force-pushed
the
hashtagchris-leading-dashes
branch
from
4a962c7 to
b95e84e
Compare
hashtagchris
commented
Dec 17, 2025
| test('validate-npm-package-name', function () { | ||
| // Traditional | ||
|
|
||
| assert.deepStrictEqual(validate('validate-npm-package-name'), { validForNewPackages: true, validForOldPackages: true }) |
Contributor
Author
There was a problem hiding this comment.
If validate-npm-package-name isn't valid, we're in trouble. 😄
owlstronaut
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject unscoped names with leading hypens (dashes). These package names are often interpreted as options on the command-line.
References
https://en.wikipedia.org/wiki/Hyphen-minus (I usually call them dashes)