Adds PPI support and example#162
Merged
jamesmunns merged 3 commits intonrf-rs:masterfrom Jun 28, 2020
Merged
Conversation
| regs.ch[P::CH].tep.write(|w| unsafe { w.bits(addr) }); | ||
| } | ||
|
|
||
| fn set_event_endpoint(&mut self, addr: u32) { |
Contributor
There was a problem hiding this comment.
The manual says that these registers "accept only addresses to registers from the Event/Task group". Does that mean that writing an incorrect address has no effect, or will that cause trouble?
Contributor
Author
There was a problem hiding this comment.
Hmm, I just tried here on hardware, I used another timer's CC0 register (TIMER1) to see if it would write something to it or hardfault, but nothing happened, no write nor fault, so I guess it just doesn't do anything ?
Contributor
Author
There was a problem hiding this comment.
I also tried with a RAM address now, same thing.
Member
There was a problem hiding this comment.
It might be really tedious, but we could define an extension trait for all of the events and tasks, it would also let us get rid of the awkward &p.RADIO.tasks_disable as *const _ as u32 dance.
Contributor
|
Awesome! I am keen to try this out! Unfortunately I have little to no experience with the PPI, so I can't really judge about the API ... |
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Member
|
Regarding the "extension trait" idea, here's a quick look for the nrf52832-pac: Events:
|
Member
|
Let me know what you think of https://github.com/thalesfragoso/nrf-hal/pull/1/files, if you like it, I can do all the target gating to get the correct tasks/events for each chip. Right now it (probably) only works on the nrf52832. |
Contributor
|
Looks good! |
* Add extension trait for tasks and events * Easier to maintain structure * Implement other crates, fix regex a bit * That's gross, but it works * Apply suggestions from code review Co-authored-by: Thales <46510852+thalesfragoso@users.noreply.github.com> * Remove nrf9160 impls * More inline always Co-authored-by: Thales <46510852+thalesfragoso@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This abstraction allows for the usage of PPI channels independently.
I would like an opinion on the
enablemethod, I think that it might have the potential to break an hypothetical abstraction, but probably won't cause any memory safety problems, should we mark it asunsafe?