Stop reexporting the PAC under target#172
Merged
jonas-schievink merged 2 commits intonrf-rs:masterfrom Jul 11, 2020
jonas-schievink:no-target
Merged
Stop reexporting the PAC under target#172jonas-schievink merged 2 commits intonrf-rs:masterfrom jonas-schievink:no-target
target#172jonas-schievink merged 2 commits intonrf-rs:masterfrom
jonas-schievink:no-target
Conversation
The HAL shims have already called it "pac". Move the common HAL over to that too.
Contributor
|
Is there a reasoning why it can't be called target anymore? I have neither preference but I'm curious. Also maybe we should include an alias to target still and add a deprecation message, such that it doesn't just explode for users. |
Contributor
Author
|
Mainly because |
Contributor
|
Ok, this is ok for me then :) I guess it's really much clearer :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #171
Now we only have a single reexport of the PAC, called
pac.