Skip to content

Added VDD source for the ADC#181

Merged
jamesmunns merged 1 commit intonrf-rs:masterfrom
diondokter:ADC_VDD
Jul 21, 2020
Merged

Added VDD source for the ADC#181
jamesmunns merged 1 commit intonrf-rs:masterfrom
diondokter:ADC_VDD

Conversation

@diondokter
Copy link
Copy Markdown
Contributor

Hey, props to you guys! This crate is really easy to add stuff in. (Well, so far at least 😉)

I missed the option for measuring the VDD voltage and all non-9160 mcu's support it.
So I added a struct and made the channel_mappings implement it for me.

The read function now checks for 'channel' 8 as well.

Copy link
Copy Markdown
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesmunns jamesmunns merged commit 1e63c04 into nrf-rs:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants