Prevent building for subtly incompatible targets#206
Merged
jonas-schievink merged 1 commit intonrf-rs:masterfrom Sep 2, 2020
jonas-schievink:incompat-targets
Merged
Prevent building for subtly incompatible targets#206jonas-schievink merged 1 commit intonrf-rs:masterfrom jonas-schievink:incompat-targets
jonas-schievink merged 1 commit intonrf-rs:masterfrom
jonas-schievink:incompat-targets
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we were doing that in the CI script. Also, the nRF52810 is the only nRF52 without an FPU, which is pretty subtle. Detect those cases and abort the build.